Update handling for bools and enums with database defaults #30843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
reviewed
May 9, 2023
| == typeof(bool) | ||
| && Equals(true, property.GetDefaultValue())) | ||
| { | ||
| propertyBuilder.HasSentinel(true); |
There was a problem hiding this comment.
You should only set the sentinel when annotation is not null and reset it when it is.
AndriySvyryd
approved these changes
May 9, 2023
Fixes #15070 - Warn for enums like we do for bools - Don't warn if a sentinel value has been configured - Update warning message to mention sentinel value - Set the sentinel by convention for non-nullable bools with a default value
ajcvickers
force-pushed
the
TrueIsFalseAndFalseIsTrue0506
branch
from
c7dcdfa
to
f9bafb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15070